帮助你审慎分析代码评审意见,核实技术合理性后再决定是否采纳。
复制安装指令,让 AI 自动完成配置 · 推荐新手
请帮我安装 askskill 上的 "receiving-code-review" 技能: 1. 下载 https://raw.githubusercontent.com/obra/superpowers/main/skills/receiving-code-review/SKILL.md 2. 保存为 ~/.claude/skills/receiving-code-review/SKILL.md 3. 装好后重载技能,告诉我可以用了
我收到一条代码评审意见:‘这里不要用缓存,会导致数据不一致,建议每次都直接查数据库。’请帮我分析这条意见是否技术上成立,需要考虑哪些上下文信息、风险和验证步骤,并给出我应如何回复评审者。
一份结构化分析,说明该意见是否成立、需要补充的技术背景、可执行的验证方法,以及专业克制的回复建议。
评审建议我把这段并发处理逻辑改成同步执行以便‘更简单易懂’。请从性能、正确性、可维护性和系统负载角度评估这个建议的利弊,并告诉我实施前应该做哪些测试或数据对比。
一份权衡分析,列出改动可能带来的收益与风险,并附上实施前的验证清单。
请帮我回复这条代码评审意见。我的目标不是直接反驳,而是基于事实澄清问题:我已经做了单元测试和基准测试,当前实现满足性能目标,但我也愿意根据更多证据调整方案。请写一段专业、礼貌、有技术依据的回复。
一段适合直接发送的评审回复,语气合作但不盲从,并清楚说明现有证据与后续行动。
Code review requires technical evaluation, not emotional performance.
Core principle: Verify before implementing. Ask before assuming. Technical correctness over social comfort.
WHEN receiving code review feedback:
1. READ: Complete feedback without reacting
2. UNDERSTAND: Restate requirement in own words (or ask)
3. VERIFY: Check against codebase reality
4. EVALUATE: Technically sound for THIS codebase?
5. RESPOND: Technical acknowledgment or reasoned pushback
6. IMPLEMENT: One item at a time, test each
NEVER:
INSTEAD:
IF any item is unclear:
STOP - do not implement anything yet
ASK for clarification on unclear items
WHY: Items may be related. Partial understanding = wrong implementation.
your human partner: "Fix 1-6"
You understand 1,2,3,6. Unclear on 4,5.
❌ WRONG: Implement 1,2,3,6 now, ask about 4,5 later
✅ RIGHT: "I understand items 1,2,3,6. Need clarification on 4 and 5 before proceeding."
BEFORE implementing:
1. Check: Technically correct for THIS codebase?
2. Check: Breaks existing functionality?
3. Check: Reason for current implementation?
4. Check: Works on all platforms/versions?
5. Check: Does reviewer understand full context?
IF suggestion seems wrong:
Push back with technical reasoning
IF can't easily verify:
Say so: "I can't verify this without [X]. Should I [investigate/ask/proceed]?"
IF conflicts with your human partner's prior decisions:
Stop and discuss with your human partner first
your human partner's rule: "External feedback - be skeptical, but check carefully"
IF reviewer suggests "implementing properly":
grep codebase for actual usage
IF unused: "This endpoint isn't called. Remove it (YAGNI)?"
IF used: Then implement properly
your human partner's rule: "You and reviewer both report to me. If we don't need this feature, don't add it."
FOR multi-item feedback:
1. Clarify anything unclear FIRST
2. Then implement in this order:
- Blocking issues (breaks, security)
- Simple fixes (typos, imports)
- Complex fixes (refactoring, logic)
3. Test each fix individually
4. Verify no regressions
Push back when:
How to push back:
Signal if uncomfortable pushing back out loud: "Strange things are afoot at the Circle K"
When feedback IS correct:
✅ "Fixed. [Brief description of what changed]"
✅ "Good catch - [specific issue]. Fixed in [location]."
✅ [Just fix it and show in the code]
❌ "You're absolutely right!"
❌ "Great point!"
❌ "Thanks for catching that!"
❌ "Thanks for [anything]"
❌ ANY gratitude expression
Why no thanks: Actions speak. Just fix it. The code itself shows you heard the feedback.
…
在宣称任务完成或修复成功前,先执行验证并用结果佐证结论。
在继续开发前发起代码审查,依据计划或需求检查实现质量与偏差。